Rollup of 12 pull requests #40446

arielb1 · 2017-03-11T19:57:51Z

Successful merges: Better docs of rusty parts of typeck #40146, Add missing example for Display::fmt #40299, Allow lints to check Bodys directly #40315, Disallow subtyping between T and U in T: Unsize<U>. #40319, save-analysis: cope with lack of method data after a type error #40344, Fix missing backtick typo #40345, Do not bother creating StorageLive for TyNever #40372, Fix UB in repr(packed) tests #40373, Update gdbr tests #40400, fix #40294 obligation cause.body_id is not always a NodeExpr #40404, Fix associated consts display #40419, rustc: Whitelist the FMA target feature #40431
Failed merges:

Fixes rendering of the end of the `Configure and Make` section.

Keeps MIR cleaner, `StorageLive(_: !)` makes no sense anyway.

gdb will now reliably detect the lanugage as rust even before any code is run.

This commit adds the entry `"fma\0"` to the whitelist for the x86 target. LLVM already supports fma but rustc did not directly. Previously rustc permitted `+fma` in the target-feature argument and enabled the use of FMA instructions, but it did not list it in the configuration and attributes. fixes rust-lang#40406

This should hopefully add support for debugging OSX and Windows presumed sccache failures instead of just the Linux ones.

Better docs of rusty parts of typeck

@frewsxcv

… r=frewsxcv Add missing example for Display::fmt r? @frewsxcv

@eddyb

Allow lints to check Bodys directly r? @eddyb babysteps towards fixing https://github.com/Manishearth/rust-clippy/issues/1580 (disable certain lints in const environments, since they make no sense there (yet))

…r=nikomatsakis Disallow subtyping between T and U in T: Unsize<U>. Because `&mut T` can be coerced to `&mut U`, `T` and `U` must be unified invariantly. Fixes rust-lang#40288. E.g. coercing `&mut [&'a X; N]` to `&mut [&'b X]` must require `'a` be equal to `'b`, otherwise you can convert between `&'a X` and `&'b X` (in either direction), potentially unsoundly lengthening lifetimes. Subtyping here was introduced with `Unsize` in rust-lang#24619 (landed in 1.1, original PR is rust-lang#23785).

@eddyb

save-analysis: cope with lack of method data after a type error Fixes rust-lang#39957 r? @eddyb

Fix missing backtick typo Fixes rendering of the end of the `Configure and Make` section.

@eddyb

Do not bother creating StorageLive for TyNever Keeps MIR cleaner, `StorageLive(_: !)` makes no sense anyway. r? @eddyb

@arielb1

Fix UB in repr(packed) tests r? @arielb1 cc rust-lang#37609 and rust-lang#27060

Update gdbr tests gdb will now reliably detect the lanugage as rust even before any code is run.

@nikomatsakis

fix rust-lang#40294 obligation cause.body_id is not always a NodeExpr Hello! This fixes rust-lang#40294 and moves tests related to rust-lang#38812 to a much more sensible directory. Thanks to @nikomatsakis and @eddyb

bors · 2017-03-11T21:48:07Z

💔 Test failed - status-travis

arielb1 · 2017-03-11T22:12:58Z

Cloning into '/home/travis/build/rust-lang/rust/src/llvm'...

No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.

Network failure

@bors retry

bors · 2017-03-11T22:22:14Z

⌛ Testing commit b1e03fe with merge 4674a74...

bors · 2017-03-11T22:48:07Z

💔 Test failed - status-travis

alexcrichton · 2017-03-11T23:00:44Z

@bors: retry * suspected sccache failure #40240

…

On Sat, Mar 11, 2017 at 4:48 PM, bors ***@***.***> wrote: 💔 Test failed - status-travis <https://travis-ci.org/rust-lang/rust/builds/210145637> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#40446 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD95G0K-pgJ51H1sY8bcrwo-X3pXT2Fks5rkySogaJpZM4MaUNa> .

alexcrichton · 2017-03-11T23:01:32Z

@bors: p=2

bors · 2017-03-12T01:08:50Z

⌛ Testing commit b1e03fe with merge bf4151b...

bors · 2017-03-12T02:12:25Z

💔 Test failed - status-appveyor

alexcrichton · 2017-03-12T02:15:11Z

@bors: retry

appveyor failed to upload to s3 Failure to upload to S3 from AppVeyor #39074

bors · 2017-03-12T02:15:28Z

⌛ Testing commit b1e03fe with merge 9ae5edd...

bors · 2017-03-12T02:46:08Z

💔 Test failed - status-travis

…rust into rollup

alexcrichton · 2017-03-12T02:50:05Z

@bors: r+

bors · 2017-03-12T02:50:06Z

📌 Commit 6a5fd0f has been approved by alexcrichton

bors · 2017-03-12T02:50:22Z

⌛ Testing commit 6a5fd0f with merge 744e696...

Rollup of 12 pull requests - Successful merges: #40146, #40299, #40315, #40319, #40344, #40345, #40372, #40373, #40400, #40404, #40419, #40431 - Failed merges:

bors · 2017-03-12T05:27:26Z

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 744e696 to master...

I have a suspicion that this caused a large regression in cycle times by forcing the compiler to perform more checks on every `debug!` statement, so let's test this out by removing the `RUST_LOG` env var globally. This regression in cycle time was witnessed between [two] [builds] where the [PR] in question didn't do much suspicious. Judging by how the stage0 times *also* regressed though then this is my best guess. [two]: https://travis-ci.org/rust-lang/rust/builds/210149932 [builds]: https://travis-ci.org/rust-lang/rust/builds/210179995 [PR]: rust-lang#40446

travis: Don't set `RUST_LOG` globally I have a suspicion that this caused a large regression in cycle times by forcing the compiler to perform more checks on every `debug!` statement, so let's test this out by removing the `RUST_LOG` env var globally. This regression in cycle time was witnessed between [two] [builds] where the [PR] in question didn't do much suspicious. Judging by how the stage0 times *also* regressed though then this is my best guess. [two]: https://travis-ci.org/rust-lang/rust/builds/210149932 [builds]: https://travis-ci.org/rust-lang/rust/builds/210179995 [PR]: #40446

bjorn3 and others added 30 commits February 28, 2017 10:57

Dont bug! on user error

53d3c89

Fix indentation in region infer docs

54a1c8b

Syntax highlighting in region infer docs

2a40918

Improve a bit more

be49671

Syntax highlight and note about current rust in infer docs

90e94d9

Fix missing backtick typo

234753a

Fixes rendering of the end of the `Configure and Make` section.

Disallow subtyping between T and U in T: Unsize<U>.

3198904

fix UB in repr(packed) tests

79a7ee8

Overhaul coercion to use the lazy InferOk obligations passing.

74bc7fd

Do not bother creating StorageLive for TyNever

84d1f6a

Keeps MIR cleaner, `StorageLive(_: !)` makes no sense anyway.

Use subtyping on the target of unsizing coercions.

cfb41ae

update gdbr tests

b95b5db

gdb will now reliably detect the lanugage as rust even before any code is run.

fix rust-lang#40294 obligation cause.body_id is not always a NodeExpr

7f19f1f

move related tests to type-check ui test directory

889337d

Add missing example for Display::fmt

a5a3981

Fix associated consts display

ea3c82c

save-analysis: cope with lack of method data after a type error

e5d1b9c

Fixes rust-lang#39957

Allow lints to check Bodys directly

b959d13

Attempt to debug sccache in more locations

c60a58b

This should hopefully add support for debugging OSX and Windows presumed sccache failures instead of just the Linux ones.

Rollup merge of rust-lang#40146 - bjorn3:few-infer-changes, r=pnkfelix

45de0f9

Better docs of rusty parts of typeck

Rollup merge of rust-lang#40299 - GuillaumeGomez:fmt-display-example,…

b933bdc

… r=frewsxcv Add missing example for Display::fmt r? @frewsxcv

Rollup merge of rust-lang#40315 - oli-obk:lint_body, r=eddyb

b49036c

Allow lints to check Bodys directly r? @eddyb babysteps towards fixing https://github.com/Manishearth/rust-clippy/issues/1580 (disable certain lints in const environments, since they make no sense there (yet))

Rollup merge of rust-lang#40344 - nrc:save-container, r=eddyb

8dc8f8f

save-analysis: cope with lack of method data after a type error Fixes rust-lang#39957 r? @eddyb

Rollup merge of rust-lang#40345 - Nashenas88:patch-1, r=estebank

037e506

Fix missing backtick typo Fixes rendering of the end of the `Configure and Make` section.

Rollup merge of rust-lang#40372 - nagisa:never-drop, r=eddyb

66436b5

Do not bother creating StorageLive for TyNever Keeps MIR cleaner, `StorageLive(_: !)` makes no sense anyway. r? @eddyb

Rollup merge of rust-lang#40373 - TimNN:test-ub-packed, r=arielb1

d75b9ad

Fix UB in repr(packed) tests r? @arielb1 cc rust-lang#37609 and rust-lang#27060

Rollup merge of rust-lang#40400 - TimNN:gdbr-updates, r=alexcrichton

25dcbca

Update gdbr tests gdb will now reliably detect the lanugage as rust even before any code is run.

Rollup merge of rust-lang#40404 - cengizIO:master, r=nikomatsakis

d208b2d

fix rust-lang#40294 obligation cause.body_id is not always a NodeExpr Hello! This fixes rust-lang#40294 and moves tests related to rust-lang#38812 to a much more sensible directory. Thanks to @nikomatsakis and @eddyb

Merge branch 'more-sccache-debug' of https://github.com/alexcrichton/…

6a5fd0f

…rust into rollup

bors added a commit that referenced this pull request Mar 12, 2017

Auto merge of #40446 - arielb1:rollup, r=alexcrichton

744e696

Rollup of 12 pull requests - Successful merges: #40146, #40299, #40315, #40319, #40344, #40345, #40372, #40373, #40400, #40404, #40419, #40431 - Failed merges:

bors merged commit 6a5fd0f into rust-lang:master Mar 12, 2017

This was referenced Mar 12, 2017

Ref suggestion #37658

Merged

change the strategy for diverging types #40224

Merged

alexcrichton mentioned this pull request Mar 20, 2017

travis: Don't set RUST_LOG globally #40686

Merged

Centril added the rollup A PR which is a rollup label Oct 2, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 12 pull requests #40446

Rollup of 12 pull requests #40446

arielb1 commented Mar 11, 2017

bors commented Mar 11, 2017

arielb1 commented Mar 11, 2017

bors commented Mar 11, 2017

bors commented Mar 11, 2017

alexcrichton commented Mar 11, 2017 via email

alexcrichton commented Mar 11, 2017

bors commented Mar 12, 2017

bors commented Mar 12, 2017

alexcrichton commented Mar 12, 2017

bors commented Mar 12, 2017

bors commented Mar 12, 2017

alexcrichton commented Mar 12, 2017

bors commented Mar 12, 2017

bors commented Mar 12, 2017

bors commented Mar 12, 2017

Rollup of 12 pull requests #40446

Rollup of 12 pull requests #40446

Conversation

arielb1 commented Mar 11, 2017

bors commented Mar 11, 2017

arielb1 commented Mar 11, 2017

bors commented Mar 11, 2017

bors commented Mar 11, 2017

alexcrichton commented Mar 11, 2017 via email

alexcrichton commented Mar 11, 2017

bors commented Mar 12, 2017

bors commented Mar 12, 2017

alexcrichton commented Mar 12, 2017

bors commented Mar 12, 2017

bors commented Mar 12, 2017

alexcrichton commented Mar 12, 2017

bors commented Mar 12, 2017

bors commented Mar 12, 2017

bors commented Mar 12, 2017